Add Push progress callbacks #21
Open
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevencl840
force-pushed
the
sjc/add-progress-callback
branch
2 times, most recently
from
e845b47 to
982aeba
Compare
stevencl840
force-pushed
the
sjc/add-progress-callback
branch
from
982aeba to
d7d187c
Compare
dylanlerch
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to capture the output of pre-receive hooks so that we can display this information to our users. Currently, if a pre-receive hook declines a push, the status error "pre-receive hook declined on branch" is returned. The output of the hook itself is not returned. This additional information is conveyed through remote progress messages and is useful to the user in determining why the hook declined the push.
Details
To achieve this, we need to wire up the
OnPushRemoteProgresshandler. The NativeMethods for receiving text updates from the remote already exist and are used in the FetchOptions. This simply adds the existing handler to PushOptions, allowing you to configure a callback for receiving text updates from the remote.This PR effectively brings the work in libgit2#1876 to our fork.